Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1112843004: Refactor to make visitDynamicSend deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolved_visitor.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index cb22f1a6f94e262f29cb4509ee0d169f674de97f..b1de2c151e1ab7a9a2e7932da9cf33f87afe7c76 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -3158,9 +3158,7 @@ class SsaBuilder extends NewResolvedVisitor {
@override
void visitIndex(ast.Send node, ast.Node receiver, ast.Node index, _) {
- // TODO(johnniwinther): Add a new helper to join the paths used by
- // [visitIndex], [visitDynamicSend] and [handleSendSet].
- visitDynamicSend(node);
+ generateDynamicSend(node);
}
@override
@@ -3685,7 +3683,8 @@ class SsaBuilder extends NewResolvedVisitor {
}
}
- visitDynamicSend(ast.Send node) {
+ /// Generate a dynamic method, getter or setter invocation.
+ void generateDynamicSend(ast.Send node) {
Selector selector = elements.getSelector(node);
List<HInstruction> inputs = <HInstruction>[];
@@ -3701,6 +3700,25 @@ class SsaBuilder extends NewResolvedVisitor {
}
@override
+ visitDynamicPropertyInvoke(
+ ast.Send node,
+ ast.Node receiver,
+ ast.NodeList arguments,
+ Selector selector,
+ _) {
+ generateDynamicSend(node);
+ }
+
+ @override
+ visitThisPropertyInvoke(
+ ast.Send node,
+ ast.NodeList arguments,
+ Selector selector,
+ _) {
+ generateDynamicSend(node);
+ }
+
+ @override
visitExpressionInvoke(
ast.Send node,
ast.Node expression,
@@ -5488,7 +5506,7 @@ class SsaBuilder extends NewResolvedVisitor {
stack.add(result);
} else if (node.isIndex) {
if ("=" == op.source) {
- visitDynamicSend(node);
+ generateDynamicSend(node);
} else {
visit(node.receiver);
HInstruction receiver = pop();
« no previous file with comments | « pkg/compiler/lib/src/resolved_visitor.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698