Refactor to make visitDynamicSend deprecated.

pkg/compiler/lib/src/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaFunctionCompiler implements FunctionCompiler {
   SsaCodeGeneratorTask generator;
   SsaBuilderTask builder;
   SsaOptimizerTask optimizer;
@@ skipping 3140 matching lines @@
   @override
   void visitBinary(ast.Send node,
                    ast.Node left,
                    BinaryOperator operator,
                    ast.Node right, _) {
     handleBinary(node, left, right);
   }
 
   @override
   void visitIndex(ast.Send node, ast.Node receiver, ast.Node index, _) {
-    // TODO(johnniwinther): Add a new helper to join the paths used by
-    // [visitIndex], [visitDynamicSend] and [handleSendSet].
-    visitDynamicSend(node);
+    generateDynamicSend(node);
   }
 
   @override
   void visitEquals(ast.Send node, ast.Node left, ast.Node right, _) {
     handleBinary(node, left, right);
   }
 
   @override
   void visitNotEquals(ast.Send node, ast.Node left, ast.Node right, _) {
     handleBinary(node, left, right);
@@ skipping 504 matching lines @@
         handleConstantForOptionalParameter);
   }
 
   void addGenericSendArgumentsToList(Link<ast.Node> link, List<HInstruction> list) {
     for (; !link.isEmpty; link = link.tail) {
       visit(link.head);
       list.add(pop());
     }
   }
 
-  visitDynamicSend(ast.Send node) {
+  /// Generate a dynamic method, getter or setter invocation.
+  void generateDynamicSend(ast.Send node) {
     Selector selector = elements.getSelector(node);
 
     List<HInstruction> inputs = <HInstruction>[];
     HInstruction receiver = generateInstanceSendReceiver(node);
     inputs.add(receiver);
     addDynamicSendArgumentsToList(node, inputs);
 
     pushInvokeDynamic(node, selector, inputs);
     if (selector.isSetter || selector.isIndexSet) {
       pop();
       stack.add(inputs.last);
     }
   }
 
   @override
+  visitDynamicPropertyInvoke(
+      ast.Send node,
+      ast.Node receiver,
+      ast.NodeList arguments,
+      Selector selector,
+      _) {
+    generateDynamicSend(node);
+  }
+
+  @override
+  visitThisPropertyInvoke(
+      ast.Send node,
+      ast.NodeList arguments,
+      Selector selector,
+      _) {
+    generateDynamicSend(node);
+  }
+
+  @override
   visitExpressionInvoke(
       ast.Send node,
       ast.Node expression,
       ast.NodeList arguments,
       Selector selector,
       _) {
     generateCallInvoke(node, visitAndPop(expression));
   }
 
   @override
@@ skipping 1767 matching lines @@
           || !setterSelector.applies(element, compiler.world)) {
         generateSuperNoSuchMethodSend(
             node, setterSelector, setterInputs);
         pop();
       } else {
         add(buildInvokeSuper(setterSelector, element, setterInputs));
       }
       stack.add(result);
     } else if (node.isIndex) {
       if ("=" == op.source) {
-        visitDynamicSend(node);
+        generateDynamicSend(node);
       } else {
         visit(node.receiver);
         HInstruction receiver = pop();
         Link<ast.Node> arguments = node.arguments;
         HInstruction index;
         if (node.isIndex) {
           visit(arguments.head);
           arguments = arguments.tail;
           index = pop();
         }
@@ skipping 2087 matching lines @@
     if (unaliased is TypedefType) throw 'unable to unalias $type';
     unaliased.accept(this, builder);
   }
 
   void visitDynamicType(DynamicType type, SsaBuilder builder) {
     JavaScriptBackend backend = builder.compiler.backend;
     ClassElement cls = backend.findHelper('DynamicRuntimeType');
     builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
   }
 }