Issue 1112813002: Make use of v8::Local alias in Source/web*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1112813002: Make use of v8::Local alias in Source/web* (Closed)

Created:
5 years, 7 months ago by deepak.s

Modified:
5 years, 7 months ago

Reviewers:
haraken

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make use of v8::Local alias in Source/web* Use v8::Local<> instead of v8::Handle<> BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194650

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -21 lines)			Patch
M	Source/web/FrameLoaderClientImpl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/FrameLoaderClientImpl.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebBindings.cpp	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/web/WebDevToolsFrontendImpl.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebPluginContainerImpl.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112813002/1

5 years, 7 months ago (2015-04-29 11:31:13 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 11:48:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194650

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages