Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2747)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1112813002: Make use of v8::Local alias in Source/web* (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebPluginContainerImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index e6bb0ec45c0cffec72644e61b31ab66489b3bab4..c39a2adc21a2bb876bc2d9b733ae46a7b8c1af5f 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -3111,7 +3111,7 @@ class ContextLifetimeTestWebFrameClient : public FrameTestHelpers::TestWebFrameC
public:
struct Notification {
public:
- Notification(WebLocalFrame* frame, v8::Handle<v8::Context> context, int worldId)
+ Notification(WebLocalFrame* frame, v8::Local<v8::Context> context, int worldId)
: frame(frame)
, context(context->GetIsolate(), context)
, worldId(worldId)
@@ -3154,12 +3154,12 @@ public:
std::vector<Notification*> releaseNotifications;
private:
- virtual void didCreateScriptContext(WebLocalFrame* frame, v8::Handle<v8::Context> context, int extensionGroup, int worldId) override
+ virtual void didCreateScriptContext(WebLocalFrame* frame, v8::Local<v8::Context> context, int extensionGroup, int worldId) override
{
createNotifications.push_back(new Notification(frame, context, worldId));
}
- virtual void willReleaseScriptContext(WebLocalFrame* frame, v8::Handle<v8::Context> context, int worldId) override
+ virtual void willReleaseScriptContext(WebLocalFrame* frame, v8::Local<v8::Context> context, int worldId) override
{
releaseNotifications.push_back(new Notification(frame, context, worldId));
}
@@ -3422,7 +3422,7 @@ TEST_F(WebFrameTest, GetFullHtmlOfPage)
class TestExecuteScriptDuringDidCreateScriptContext : public FrameTestHelpers::TestWebFrameClient {
public:
- virtual void didCreateScriptContext(WebLocalFrame* frame, v8::Handle<v8::Context> context, int extensionGroup, int worldId) override
+ virtual void didCreateScriptContext(WebLocalFrame* frame, v8::Local<v8::Context> context, int extensionGroup, int worldId) override
{
frame->executeScript(WebScriptSource("window.history = 'replaced';"));
}
@@ -4316,7 +4316,7 @@ protected:
const WebSelectionBound* selectEnd = m_fakeSelectionLayerTreeView.end();
v8::HandleScope handleScope(v8::Isolate::GetCurrent());
- v8::Handle<v8::Value> result = m_webViewHelper.webView()->mainFrame()->toWebLocalFrame()->executeScriptAndReturnValue(WebScriptSource("expectedResult"));
+ v8::Local<v8::Value> result = m_webViewHelper.webView()->mainFrame()->toWebLocalFrame()->executeScriptAndReturnValue(WebScriptSource("expectedResult"));
if (result.IsEmpty() || (*result)->IsUndefined()) {
EXPECT_FALSE(selection);
EXPECT_FALSE(selectStart);
« no previous file with comments | « Source/web/WebPluginContainerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698