Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1112573002: [chrome/browser/extensions] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, dkrahn+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome browser extensions module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/073007884e53864c17468be392431903be8e718e Cr-Commit-Position: refs/heads/master@{#328118}

Patch Set 1 #

Patch Set 2 : Fixed nits #

Patch Set 3 : Fixed other nits #

Total comments: 2

Patch Set 4 : Fixed Review Comments #

Total comments: 2

Patch Set 5 : Resolving ng browser unittest issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -51 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc View 1 2 3 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/mime_util.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_property_provider.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_port.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/blacklist.cc View 1 2 5 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/blacklist_state_fetcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/blacklist_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_test_base.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/fake_safe_browsing_database_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_blacklist.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_blacklist_state_fetcher.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/zipfile_installer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/zipfile_installer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 22 (7 generated)
Pranay
PTAL
5 years, 7 months ago (2015-04-29 03:28:45 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/1112573002/diff/40001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc (right): https://codereview.chromium.org/1112573002/diff/40001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc#newcode8 chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc:8: #include "base/message_loop/message_loop.h" Also remove the includes for MessageLoop, here ...
5 years, 7 months ago (2015-04-29 16:13:49 UTC) #3
Pranay
Hi Kalman, Thanks for the review :) Removed "message_loop.h" from all those files where it's ...
5 years, 7 months ago (2015-04-30 04:17:02 UTC) #4
not at google - send to devlin
lgtm but run "git cl format" before submitting. thanks for the patch! https://codereview.chromium.org/1112573002/diff/60001/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc File chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ...
5 years, 7 months ago (2015-04-30 16:19:57 UTC) #5
Pranay
Hi Kalman, Thanks for LGTM, have run "git cl format" already on this change but ...
5 years, 7 months ago (2015-05-04 03:02:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112573002/60001
5 years, 7 months ago (2015-05-04 03:02:54 UTC) #8
Pranay
Done https://codereview.chromium.org/1112573002/diff/40001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc (right): https://codereview.chromium.org/1112573002/diff/40001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc#newcode8 chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc:8: #include "base/message_loop/message_loop.h" On 2015/04/29 16:13:49, kalman wrote: > ...
5 years, 7 months ago (2015-05-04 03:19:56 UTC) #9
Pranay
Thanks kalman, git cl format is already been done, didn't observe any message regarding the ...
5 years, 7 months ago (2015-05-04 03:23:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/60664)
5 years, 7 months ago (2015-05-04 04:27:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112573002/60001
5 years, 7 months ago (2015-05-04 04:33:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/61701)
5 years, 7 months ago (2015-05-04 05:27:46 UTC) #16
Pranay
5 years, 7 months ago (2015-05-04 06:15:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112573002/80001
5 years, 7 months ago (2015-05-04 13:09:00 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-04 14:04:09 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 14:05:10 UTC) #22
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/073007884e53864c17468be392431903be8e718e
Cr-Commit-Position: refs/heads/master@{#328118}

Powered by Google App Engine
This is Rietveld 408576698