chrome/browser/extensions/startup_helper.cc - Issue 1112573002: [chrome/browser/extensions] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/startup_helper.cc

Issue 1112573002: [chrome/browser/extensions] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving ng browser unittest issues Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/fake_safe_browsing_database_manager.cc ('k') | chrome/browser/extensions/test_blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/startup_helper.cc

diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc

index 07c868bdc75eb0586861b95f604ab1d1fde4568b..c435799a1973f1b9fea0afe0f7a4f28736e343e8 100644

--- a/chrome/browser/extensions/startup_helper.cc

+++ b/chrome/browser/extensions/startup_helper.cc

@@ -10,6 +10,7 @@

#include "base/files/file_path.h"

#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

@@ -174,7 +175,7 @@ class ValidateCrxHelper : public SandboxedUnpackerClient {

void StartOnFileThread() {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

- scoped_refptr<base::MessageLoopProxy> file_thread_proxy =

+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner =

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE);

scoped_refptr<SandboxedUnpacker> unpacker(

@@ -182,7 +183,7 @@ class ValidateCrxHelper : public SandboxedUnpackerClient {

Manifest::INTERNAL,

0, /* no special creation flags */

temp_dir_,

- file_thread_proxy.get(),

+ file_task_runner.get(),

this));

unpacker->Start();

}

« no previous file with comments | « chrome/browser/extensions/fake_safe_browsing_database_manager.cc ('k') | chrome/browser/extensions/test_blacklist.cc » ('j') | no next file with comments »