Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tool/input_sdk/lib/core/list.dart

Issue 1112403004: SDK fixes (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Formatting fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/input_sdk/lib/core/list.dart
diff --git a/tool/input_sdk/lib/core/list.dart b/tool/input_sdk/lib/core/list.dart
index 19a22eb01dde28ee414f606022afb06e7a8e922e..20dce08cca7921258acd443037173e658c8924e4 100644
--- a/tool/input_sdk/lib/core/list.dart
+++ b/tool/input_sdk/lib/core/list.dart
@@ -229,11 +229,6 @@ abstract class List<E> implements Iterable<E>, EfficientLength {
bool every(bool f(E element)) => IterableMixinWorkaround.every(this, f);
- void sort([int compare(E a, E b)]) {
- checkMutable('sort');
- IterableMixinWorkaround.sortList(this, compare);
- }
-
bool contains(Object other) {
for (int i = 0; i < length; i++) {
if (this[i] == other) return true;
@@ -353,7 +348,7 @@ abstract class List<E> implements Iterable<E>, EfficientLength {
nums.join(', '); // '-11, 2, 13'
*/
void sort([int compare(E a, E b)]) {
- // XXX checkMutable('sort');
vsm 2015/05/04 21:09:21 Is this cleaning up a previous hack of ours?
Leaf 2015/05/04 21:50:42 I asked jacobr about this - the commented out chec
+ checkMutable('sort');
IterableMixinWorkaround.sortList(this, compare);
}

Powered by Google App Engine
This is Rietveld 408576698