SDK fixes

tool/input_sdk/lib/core/list.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * An indexable collection of objects with a length.
  *
  * Subclasses of this class implement different kinds of lists.
@@ skipping 211 matching lines @@
   E get single {
     if (length == 1) return this[0];
     if (length == 0) throw new StateError("No elements");
     throw new StateError("More than one element");
   }
 
   bool any(bool f(E element)) => IterableMixinWorkaround.any(this, f);
 
   bool every(bool f(E element)) => IterableMixinWorkaround.every(this, f);
 
-  void sort([int compare(E a, E b)]) {
-    checkMutable('sort');
-    IterableMixinWorkaround.sortList(this, compare);
-  }
-
   bool contains(Object other) {
     for (int i = 0; i < length; i++) {
       if (this[i] == other) return true;
     }
     return false;
   }
 
   bool get isEmpty => length == 0;
 
   bool get isNotEmpty => !isEmpty;
@@ skipping 99 matching lines @@
    *     numbers.join(', '); // 'one, two, four, three'
    *
    * The default List implementations use [Comparable.compare] if
    * [compare] is omitted.
    *
    *     List<int> nums = [13, 2, -11];
    *     nums.sort();
          nums.join(', '); // '-11, 2, 13'
    */
   void sort([int compare(E a, E b)]) {
-    // XXX checkMutable('sort');

[vsm, 2015/05/04 21:09:21]

Is this cleaning up a previous hack of ours?

[Leaf, 2015/05/04 21:50:42]

I asked jacobr about this - the commented out checkMutable was a temporary hack,
no longer needed.  Not sure why there were two versions of sort in the code -
probably a bad merge or an edit fail.

+    checkMutable('sort');
     IterableMixinWorkaround.sortList(this, compare);
   }
 
   /**
    * Shuffles the elements of this list randomly.
    */
   void shuffle([Random random]) {
     IterableMixinWorkaround.shuffleList(this, random);
   }
 
@@ skipping 346 matching lines @@
    *
    *     List<String> words = ['fee', 'fi', 'fo', 'fum'];
    *     Map<int, String> map = words.asMap();
    *     map[0] + map[1];   // 'feefi';
    *     map.keys.toList(); // [0, 1, 2, 3]
    */
   Map<int, E> asMap() {
     return new IterableMixinWorkaround<E>().asMapList(this);
   }
 }