Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1112123002: Precise bitwise-xor derived result type for all int32 input types.

Created:
5 years, 7 months ago by dougc
Modified:
4 years, 9 months ago
Reviewers:
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Precise bitwise-xor derived result type for all int32 input types. This one is pending too. The type derivation for this and the related patches have been split out into separate functions to speed testing. If the style for one can be settled then I'll update them all. BUG=

Patch Set 1 #

Patch Set 2 : Split the bitwise-xor result type derivation into a separate function. #

Patch Set 3 : Split the bitwise-xor result type derivation into a separate function. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -14 lines) Patch
M src/compiler/typer.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 1 chunk +104 lines, -14 lines 1 comment Download
M test/unittests/compiler/typer-unittest.cc View 1 2 chunks +43 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
dougc
5 years, 7 months ago (2015-05-13 14:41:08 UTC) #2
titzer
https://codereview.chromium.org/1112123002/diff/40001/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/1112123002/diff/40001/src/compiler/typer.cc#newcode963 src/compiler/typer.cc:963: uint32_t rmin, uint32_t rmax) { Maybe pull these methods ...
5 years, 7 months ago (2015-05-13 14:44:37 UTC) #3
Sven Panne
5 years, 7 months ago (2015-05-18 12:16:15 UTC) #5
https://codereview.chromium.org/1112123002/diff/40001/test/unittests/compiler...
File test/unittests/compiler/typer-unittest.cc (right):

https://codereview.chromium.org/1112123002/diff/40001/test/unittests/compiler...
test/unittests/compiler/typer-unittest.cc:307:
TestPreciseBinaryArithOp<bit_xor>(JSBitwiseXorIntType,
How long do these tests actually run? 6 nested for loops look scary, see my
comment for the similar shift_right CL.

Powered by Google App Engine
This is Rietveld 408576698