Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1111903002: win: Move DXVAVideoDecodeAccelerator's WeakPtrFactory member to the end. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, ananta
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Move DXVAVideoDecodeAccelerator's WeakPtrFactory member to the end. Also fix initialization of weak_ptr_ which I had unintentionally broken in https://codereview.chromium.org/1103713003 BUG=303818, 467287 Committed: https://crrev.com/3b97c2fbfb7f2d6854d98659eebfdadbf272a0c7 Cr-Commit-Position: refs/heads/master@{#327366}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
5 years, 7 months ago (2015-04-28 20:21:21 UTC) #2
dmichael (off chromium)
d'oh, sorry I missed weak_ptr_ in the last review. I thought I looked for that ...
5 years, 7 months ago (2015-04-28 20:24:53 UTC) #3
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-04-28 20:35:28 UTC) #4
Nico
On 2015/04/28 20:24:53, dmichael (off chromium) wrote: > d'oh, sorry I missed weak_ptr_ in the ...
5 years, 7 months ago (2015-04-28 20:37:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111903002/20001
5 years, 7 months ago (2015-04-28 20:38:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 21:38:30 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 21:40:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b97c2fbfb7f2d6854d98659eebfdadbf272a0c7
Cr-Commit-Position: refs/heads/master@{#327366}

Powered by Google App Engine
This is Rietveld 408576698