Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1103713003: win: Move a few WeakPtrFactories to the end of their containing classes. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, peter+watch_chromium.org, wjia+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Move a few WeakPtrFactories to the end of their containing classes. Fixes some [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition. warnings and also makes the code more correct. BUG=303818, 467287 TBR=avi Committed: https://crrev.com/f82c96f4d8307db54f7908da726d1fd110d1b038 Cr-Commit-Position: refs/heads/master@{#326803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M chrome/browser/local_discovery/wifi/wifi_manager_nonchromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 2 chunks +6 lines, -4 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/native_menu_win.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Nico
5 years, 8 months ago (2015-04-23 22:30:39 UTC) #2
dmichael (off chromium)
lgtm, thanks
5 years, 8 months ago (2015-04-24 14:48:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103713003/1
5 years, 8 months ago (2015-04-24 15:12:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58814)
5 years, 8 months ago (2015-04-24 15:19:40 UTC) #7
Nico
+avi owner tbr for trivial contents change
5 years, 8 months ago (2015-04-24 15:29:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103713003/1
5 years, 8 months ago (2015-04-24 15:30:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 15:35:53 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f82c96f4d8307db54f7908da726d1fd110d1b038 Cr-Commit-Position: refs/heads/master@{#326803}
5 years, 8 months ago (2015-04-24 15:36:50 UTC) #13
Avi (use Gerrit)
5 years, 8 months ago (2015-04-24 15:43:29 UTC) #14
Message was sent while issue was closed.
lgtm

stampity stamp

Powered by Google App Engine
This is Rietveld 408576698