Chromium Code Reviews

Issue 1111863002: fix static members in _emitMemberName (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix static members in _emitMemberName static/top-levels don't need extension method, operator renames, or different slots* for private members (static members are qualified by the static type, so they aren't ambiguous, e.g. Foo._foo and Bar._foo where Foo and Bar are in same/different libraries) R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/785d4c74ffda3656248194286bf2b5ee4fb849d3

Patch Set 1 #

Patch Set 2 : catch more cases #

Unified diffs Side-by-side diffs Stats (+995 lines, -1207 lines)
M lib/runtime/dart/_interceptors.js View 11 chunks +32 lines, -43 lines 0 comments
M lib/runtime/dart/_internal.js View 14 chunks +27 lines, -32 lines 0 comments
M lib/runtime/dart/_isolate_helper.js View 22 chunks +37 lines, -51 lines 0 comments
M lib/runtime/dart/_js_helper.js View 14 chunks +18 lines, -24 lines 0 comments
M lib/runtime/dart/_native_typed_data.js View 37 chunks +181 lines, -188 lines 0 comments
M lib/runtime/dart/async.js View 94 chunks +200 lines, -250 lines 0 comments
M lib/runtime/dart/collection.js View 59 chunks +162 lines, -186 lines 0 comments
M lib/runtime/dart/convert.js View 28 chunks +47 lines, -64 lines 0 comments
M lib/runtime/dart/core.js View 83 chunks +245 lines, -327 lines 0 comments
M lib/runtime/dart/isolate.js View 3 chunks +2 lines, -3 lines 0 comments
M lib/runtime/dart/math.js View 5 chunks +18 lines, -21 lines 0 comments
M lib/runtime/dart/typed_data.js View 1 chunk +3 lines, -3 lines 0 comments
M lib/src/codegen/js_codegen.dart View 4 chunks +21 lines, -12 lines 0 comments
M test/codegen/expect/names.js View 1 chunk +1 line, -1 line 0 comments
M test/codegen/expect/opassign.js View 1 chunk +1 line, -2 lines 0 comments

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-04-28 19:34:20 UTC) #2
Jennifer Messerly
Found some more cases that weren't handled.
5 years, 7 months ago (2015-04-29 19:44:08 UTC) #3
Jacob
lgtm
5 years, 7 months ago (2015-04-29 21:38:38 UTC) #4
Jennifer Messerly
5 years, 7 months ago (2015-04-29 21:45:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
785d4c74ffda3656248194286bf2b5ee4fb849d3 (presubmit successful).

Powered by Google App Engine