fix static members in _emitMemberName

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet, HashMap;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/src/generated/ast.dart' hide ConstantEvaluator;
@@ skipping 1259 matching lines @@
         code = 'dart.$DCALL(#, #)';
       } else {
         code = '#(#)';
       }
       return js.call(
           code, [_visit(node.methodName), _visit(node.argumentList)]);
     }
 
     var type = getStaticType(target);
     var name = node.methodName.name;
-    var memberName = _emitMemberName(name, type: type);
+    var element = node.methodName.staticElement;
+    bool isStatic = element is ExecutableElement && element.isStatic;
+    var memberName = _emitMemberName(name, type: type, isStatic: isStatic);
 
     if (rules.isDynamicTarget(target)) {
       code = 'dart.$DSEND(#, #, #)';
     } else if (rules.isDynamicCall(node.methodName)) {
       // This is a dynamic call to a statically know target. For example:
       //     class Foo { Function bar; }
       //     new Foo().bar(); // dynamic call
       code = 'dart.$DCALL(#.#, #)';
     } else if (_requiresStaticDispatch(target, name)) {
       assert(rules.objectMembers[name] is FunctionType);
@@ skipping 606 matching lines @@
     if (!type.isObject &&
         !_isJSBuiltinType(type) &&
         _isNonNullableExpression(target)) {
       return false;
     }
     return true;
   }
 
   /// Shared code for [PrefixedIdentifier] and [PropertyAccess].
   JS.Expression _emitGet(Expression target, SimpleIdentifier memberId) {
-    var name = _emitMemberName(memberId.name, type: getStaticType(target));
+    var member = memberId.staticElement;
+    bool isStatic = member is ExecutableElement && member.isStatic;
+    var name = _emitMemberName(memberId.name,
+        type: getStaticType(target), isStatic: isStatic);
     if (rules.isDynamicTarget(target)) {
       return js.call('dart.$DLOAD(#, #)', [_visit(target), name]);
     }
 
     String code;
-    var member = memberId.staticElement;
     if (member != null && member is MethodElement) {
       // Tear-off methods: explicitly bind it.
       if (_requiresStaticDispatch(target, memberId.name)) {
         return js.call('dart.#.bind(#)', [name, _visit(target)]);
       }
       if (isStateless(target, target)) {
         return js.call('#.#.bind(#)', [_visit(target), name, _visit(target)]);
       }
       code = 'dart.bind(#, #)';
     } else if (_requiresStaticDispatch(target, memberId.name)) {
@@ skipping 427 matching lines @@
   /// <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map>
   ///
   /// Unary minus looks like: `x['unary-']()`. Note that [unary] must be passed
   /// for this transformation to happen, otherwise binary minus is assumed.
   ///
   /// Equality is a bit special, it is generated via the Dart `equals` runtime
   /// helper, that checks for null. The user defined method is called '=='.
   ///
   JS.Expression _emitMemberName(String name,
       {DartType type, bool unary: false, bool isStatic: false}) {
+
+    // Static methods skip most of the rename steps.
+    if (isStatic) {
+      if (invalidJSStaticMethodName(name)) {
+        // Choose an string name. Use an invalid identifier so it won't conflict
+        // with any valid member names.
+        // TODO(jmesserly): this works around the problem, but I'm pretty sure we
+        // don't need it, as static methods seemed to work. The only concrete
+        // issue we saw was in the defineNamedConstructor helper function.
+        name = '$name*';
+      }
+      return _propertyName(name);
+    }
+
     if (name.startsWith('_')) {
       return _privateNames.putIfAbsent(
           name, () => _initSymbol(new JSTemporary(name)));
     }
 
     // Check for extension method:
     var extLibrary = _findExtensionLibrary(name, type);
 
     if (name == '[]') {
       name = 'get';
     } else if (name == '[]=') {
       name = 'set';
     } else if (name == '-' && unary) {
       name = 'unary-';
     }
 
-    if (isStatic && invalidJSStaticMethodName(name)) {
-      // Choose an string name. Use an invalid identifier so it won't conflict
-      // with any valid member names.
-      // TODO(jmesserly): this works around the problem, but I'm pretty sure we
-      // don't need it, as static methods seemed to work. The only concrete
-      // issue we saw was in the defineNamedConstructor helper function.
-      name = '$name*';
-    }
-
     if (extLibrary != null) {
       return _extensionMethodName(name, extLibrary);
     }
 
     return _propertyName(name);
   }
 
   LibraryElement _findExtensionLibrary(String name, DartType type) {
     if (type is! InterfaceType) return null;
 
@@ skipping 115 matching lines @@
 // TODO(jmesserly): validate the library. See issue #135.
 bool _isJsNameAnnotation(DartObjectImpl value) => value.type.name == 'JsName';
 
 bool _isJsPeerInterface(DartObjectImpl value) =>
     value.type.name == 'JsPeerInterface';
 
 // TODO(jacobr): we would like to do something like the following
 // but we don't have summary support yet.
 // bool _supportJsExtensionMethod(AnnotatedNode node) =>
 //    _getAnnotation(node, "SupportJsExtensionMethod") != null;