Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1111803005: fix #159, static renames for caller/arguments (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -21 lines) Patch
M lib/runtime/dart_runtime.js View 1 2 3 4 3 chunks +7 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 3 2 chunks +4 lines, -13 lines 0 comments Download
M lib/src/codegen/js_names.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/names.js View 1 2 3 1 chunk +17 lines, -4 lines 0 comments Download
M test/codegen/names.dart View 2 chunks +7 lines, -0 lines 0 comments Download
A test/codegen/names.html View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jennifer Messerly
5 years, 7 months ago (2015-04-28 21:32:45 UTC) #2
Jennifer Messerly
+jacobr
5 years, 7 months ago (2015-04-29 21:42:30 UTC) #4
Jacob
lgtm https://codereview.chromium.org/1111803005/diff/60001/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1111803005/diff/60001/lib/runtime/dart_runtime.js#newcode763 lib/runtime/dart_runtime.js:763: defineProperty(clazz, name, { value: ctor, configurable: true }); ...
5 years, 7 months ago (2015-04-29 21:53:19 UTC) #5
Jennifer Messerly
https://codereview.chromium.org/1111803005/diff/60001/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1111803005/diff/60001/lib/runtime/dart_runtime.js#newcode763 lib/runtime/dart_runtime.js:763: defineProperty(clazz, name, { value: ctor, configurable: true }); On ...
5 years, 7 months ago (2015-04-29 23:07:33 UTC) #6
Jennifer Messerly
5 years, 7 months ago (2015-04-29 23:07:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
dc0592d77a1eef9c4de0faec58a871ac49e36b27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698