lib/src/codegen/js_names.dart - Issue 1111803005: fix #159, static renames for caller/arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_names.dart

Issue 1111803005: fix #159, static renames for caller/arguments (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_names.dart

diff --git a/lib/src/codegen/js_names.dart b/lib/src/codegen/js_names.dart

index 2ca5fe2ab47ab031366d4dd646d2d0e227491628..9d03bc37cb69d7939447509fe15f37d92c391ac4 100644

--- a/lib/src/codegen/js_names.dart

+++ b/lib/src/codegen/js_names.dart

@@ -231,9 +231,9 @@ bool invalidVariableName(String keyword, {bool strictMode: true}) {

return false;

}

-/// Returns true for invalid static method names in strict mode.

+/// Returns true for invalid static field names in strict mode.

/// In particular, "caller" "callee" and "arguments" cannot be used.

-bool invalidStaticMethodName(String name) {

+bool invalidStaticFieldName(String name) {

switch (name) {

case "arguments":

case "caller":

« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/names.js » ('j') | no next file with comments »