chrome/browser/extensions/extension_apitest.cc - Issue 11117011: Keep browser process alive while there are platform apps with background pages running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 11117011: Keep browser process alive while there are platform apps with background pages running. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates for tests Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc ('K') | « chrome/browser/extensions/extension_apitest.h ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_apitest.cc

diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc

index f70b3b12768c29246d9d2cbd02a4ed3c31b930c9..698ae40cdcd25a338ba37903ae70566724e933eb 100644

--- a/chrome/browser/extensions/extension_apitest.cc

+++ b/chrome/browser/extensions/extension_apitest.cc

@@ -6,8 +6,8 @@

#include "base/string_util.h"

#include "base/stringprintf.h"

-#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/api/test/test_api.h"

+#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/unpacked_installer.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

@@ -173,6 +173,13 @@ bool ExtensionApiTest::RunPageTest(const std::string& page_url,

}

bool ExtensionApiTest::RunPlatformAppTest(const char* extension_name) {

+ bool res = RunPlatformAppTestReturnImmediately(extension_name);

+ CloseShellWindowsAndWaitForAppToExit();

+ return res;

+bool ExtensionApiTest::RunPlatformAppTestReturnImmediately(

+ const char* extension_name) {

return RunExtensionTestImpl(extension_name, "", kFlagLaunchPlatformApp);

}