chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc - Issue 11117011: Keep browser process alive while there are platform apps with background pages running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

Issue 11117011: Keep browser process alive while there are platform apps with background pages running. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates for tests Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/socket/socket_apitest.cc ('k') | chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

index b5bc79cefabf93edb2073e85a2bdf45ad59ba723..7e1e180f8ab5a92ce2236907c4f3b97ed124f75a 100644

--- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

+++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

@@ -58,13 +58,11 @@ class SyncFileSystemApiTest : public ExtensionApiTest {

} // namespace

// TODO(calvinlo): Add Chrome OS support for syncable file system

-#if !defined(OS_CHROMEOS)

-// TODO(calvinlo): Add Chrome OS support for syncable file system

// (http://crbug.com/160693)

#if !defined(OS_CHROMEOS)

-// TODO(benwells): Re-enable this test.

+// TODO(calvinlo): Re-enable this test.

+// (http://crbug.com/162811)

IN_PROC_BROWSER_TEST_F(SyncFileSystemApiTest, DISABLED_DeleteFileSystem) {

ASSERT_TRUE(RunPlatformAppTest("sync_file_system/delete_file_system"))

<< message_;

@@ -89,7 +87,5 @@ IN_PROC_BROWSER_TEST_F(SyncFileSystemApiTest, WriteFileThenGetUsage) {

#endif // !defined(OS_CHROMEOS)

benwells 2012/11/27 10:18:31 This is not in the local file. I'm not sure why it

-#endif // !defined(OS_CHROMEOS)

} // namespace chrome