Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1111613002: chrome/installer/util: Fix warnings found by clang chromium-style plugin on Windows. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Nico, grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/installer/util: Fix warnings found by clang chromium-style plugin on Windows. http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/611/steps/compile/logs/stdio This fixes the following kind or warnings: warning(clang): [chromium-style] Complex constructor has an inline body. warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line destructor. BUG=467287 R=thakis@chromium.org,grt@chromium.org Committed: https://crrev.com/c5ab93d728a42b9eeeea4994097aed1b2fcea478 Cr-Commit-Position: refs/heads/master@{#327217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M chrome/installer/util/conditional_work_item_list.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/conditional_work_item_list.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/installer/util/shell_util.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
5 years, 8 months ago (2015-04-27 23:07:23 UTC) #1
Nico
lgtm!
5 years, 8 months ago (2015-04-27 23:15:55 UTC) #2
grt (UTC plus 2)
lgtm2. thanks for the cleanup!
5 years, 8 months ago (2015-04-28 02:01:09 UTC) #3
grt (UTC plus 2)
On 2015/04/28 02:01:09, grt wrote: > lgtm2. thanks for the cleanup! lgtm without the too ...
5 years, 8 months ago (2015-04-28 02:01:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111613002/1
5 years, 8 months ago (2015-04-28 02:02:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 02:06:16 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 02:07:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5ab93d728a42b9eeeea4994097aed1b2fcea478
Cr-Commit-Position: refs/heads/master@{#327217}

Powered by Google App Engine
This is Rietveld 408576698