Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Side by Side Diff: chrome/installer/util/conditional_work_item_list.cc

Issue 1111613002: chrome/installer/util: Fix warnings found by clang chromium-style plugin on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/util/conditional_work_item_list.h ('k') | chrome/installer/util/shell_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/conditional_work_item_list.h" 5 #include "chrome/installer/util/conditional_work_item_list.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 ConditionalWorkItemList::ConditionalWorkItemList(Condition* condition) 10 ConditionalWorkItemList::ConditionalWorkItemList(Condition* condition)
(...skipping 17 matching lines...) Expand all
28 VLOG(1) << "Rolling back conditional list " << log_message_; 28 VLOG(1) << "Rolling back conditional list " << log_message_;
29 WorkItemList::Rollback(); 29 WorkItemList::Rollback();
30 } 30 }
31 31
32 // Pre-defined conditions: 32 // Pre-defined conditions:
33 //------------------------------------------------------------------------------ 33 //------------------------------------------------------------------------------
34 bool ConditionRunIfFileExists::ShouldRun() const { 34 bool ConditionRunIfFileExists::ShouldRun() const {
35 return base::PathExists(key_path_); 35 return base::PathExists(key_path_);
36 } 36 }
37 37
38 Not::Not(WorkItem::Condition* original_condition)
39 : original_condition_(original_condition) {
40 }
41
42 Not::~Not() {
43 }
44
38 bool Not::ShouldRun() const { 45 bool Not::ShouldRun() const {
39 return !original_condition_->ShouldRun(); 46 return !original_condition_->ShouldRun();
40 } 47 }
41
OLDNEW
« no previous file with comments | « chrome/installer/util/conditional_work_item_list.h ('k') | chrome/installer/util/shell_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698