Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1111603004: removing equality / compute invariant loops from GrGeometryProcessors (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

removing equality / compute invariant loops from GrGeometryProcessors BUG=skia: Committed: https://skia.googlesource.com/skia/+/ef292a0901205b9785a30daae2c036aa34a970ca Committed: https://skia.googlesource.com/skia/+/1ba8cc9193f13a812401e14b8037fdcf3f3acbac

Patch Set 1 #

Patch Set 2 : one more tiny cleanup #

Patch Set 3 : tweaks #

Patch Set 4 : rebase #

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -532 lines) Patch
M gyp/gpu.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 3 3 chunks +1 line, -21 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 3 chunks +2 lines, -9 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 7 chunks +1 line, -35 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 2 chunks +11 lines, -52 lines 0 comments Download
D src/gpu/GrGeometryProcessor.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 6 chunks +0 lines, -60 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 2 3 4 1 chunk +1 line, -5 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 1 2 3 chunks +0 lines, -27 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 5 chunks +0 lines, -50 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 2 2 chunks +3 lines, -13 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 2 4 chunks +3 lines, -43 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 3 8 chunks +0 lines, -64 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 1 2 5 chunks +9 lines, -36 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 2 10 chunks +6 lines, -76 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
joshualitt
ptal
5 years, 7 months ago (2015-04-28 15:00:26 UTC) #2
bsalomon
5 years, 7 months ago (2015-04-28 15:38:38 UTC) #3
bsalomon
On 2015/04/28 15:38:38, bsalomon wrote: I meant lgtm
5 years, 7 months ago (2015-04-28 15:38:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111603004/20001
5 years, 7 months ago (2015-04-28 16:04:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/ef292a0901205b9785a30daae2c036aa34a970ca
5 years, 7 months ago (2015-04-28 16:08:32 UTC) #8
joshualitt
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1110993002/ by joshualitt@google.com. ...
5 years, 7 months ago (2015-04-28 16:16:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111603004/80001
5 years, 7 months ago (2015-05-13 18:20:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111603004/80001
5 years, 7 months ago (2015-05-13 19:23:53 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:24:28 UTC) #18
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/1ba8cc9193f13a812401e14b8037fdcf3f3acbac

Powered by Google App Engine
This is Rietveld 408576698