Issue 1111593002: Fix incorrect assert() for interrupted/paused/in progress downloads.

Issue 1111593002: Fix incorrect assert() for interrupted/paused/in progress downloads. (Closed)

Created:
5 years, 7 months ago by Dan Beam

Modified:
5 years, 7 months ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix incorrect assert() for interrupted/paused/in progress downloads. R=rdsmith@chromium.org BUG=481664 Committed: https://crrev.com/f4617bb4a4d989933ca60a050605478f2737b9ab Cr-Commit-Position: refs/heads/master@{#327185}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	chrome/browser/resources/downloads/item_view.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/webui/downloads_ui_browsertest.js	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

Randy Smith (Not in Mondays)

As noted offline, LGTM presuming this actually fixes the manual reproduction on the mac laptop.

5 years, 7 months ago (2015-04-27 22:50:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111593002/20001

5 years, 7 months ago (2015-04-28 00:03:16 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-28 00:08:56 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/f4617bb4a4d989933ca60a050605478f2737b9ab
Cr-Commit-Position: refs/heads/master@{#327185}