Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/ui/webui/downloads_ui_browsertest.js

Issue 1111593002: Fix incorrect assert() for interrupted/paused/in progress downloads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests i'm running locally Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/downloads/item_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/downloads_ui_browsertest.js
diff --git a/chrome/browser/ui/webui/downloads_ui_browsertest.js b/chrome/browser/ui/webui/downloads_ui_browsertest.js
index 0eb73ac176f7cde05908d70e86fa2c2e1777a7bd..96ffd197beb8594123341f7170e28f4ad52efb22 100644
--- a/chrome/browser/ui/webui/downloads_ui_browsertest.js
+++ b/chrome/browser/ui/webui/downloads_ui_browsertest.js
@@ -96,6 +96,18 @@ TEST_F('BaseDownloadsWebUITest', 'DatesCollapse', function() {
expectGT(firstContainer.querySelector('.date').textContent.trim().length, 0);
});
+TEST_F('BaseDownloadsWebUITest', 'EmptyProgressStatusText', function() {
+ this.createdDownloads[0].state = downloads.Item.States.PAUSED;
+ this.createdDownloads[0].progress_status_text = '';
+ downloads.Manager.updateItem(this.createdDownloads[0]); // Might assert().
+});
+
+TEST_F('BaseDownloadsWebUITest', 'EmptyLastStatusText', function() {
+ this.createdDownloads[0].state = downloads.Item.States.INTERRUPTED;
+ this.createdDownloads[0].last_reason_text = '';
+ downloads.Manager.updateItem(this.createdDownloads[0]); // Might assert().
+});
+
/**
* @constructor
* @extends {BaseDownloadsWebUITest}
« no previous file with comments | « chrome/browser/resources/downloads/item_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698