Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1111503003: Revert of Switch to STA mode for audio thread and WASAPI I/O streams. (Closed)

Created:
5 years, 8 months ago by DaleCurtis
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch to STA mode for audio thread and WASAPI I/O streams. (patchset #9 id:200001 of https://codereview.chromium.org/1097553003/) Reason for revert: Does not seem to have helped anything, crashes are still present and UMA metrics are unchanged. If anything it may have caused issues like: http://crbug.com/480476 and http://crbug.com/481581 Original issue's description: > Switch to STA mode for audio thread and WASAPI I/O streams. > > Using COM marshalling to share necessary worker thread pointers > with the render and capture threads. > > BUG=422522 > TEST=all unit tests pass, audio input and output work. > > Committed: https://crrev.com/43f3b0d25752d924390a4d6fc868d6e9469edc4f > Cr-Commit-Position: refs/heads/master@{#326360} TBR=tommi@chromium.org,henrika@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=422522 Committed: https://crrev.com/b70e5168cb06cefc077b0cfced369409941c52e4 Cr-Commit-Position: refs/heads/master@{#327115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -323 lines) Patch
M media/audio/audio_input_volume_unittest.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M media/audio/audio_manager.cc View 2 chunks +1 line, -14 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/audio/audio_manager_unittest.cc View 2 chunks +15 lines, -3 lines 0 comments Download
M media/audio/win/audio_device_listener_win_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win.h View 3 chunks +5 lines, -22 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 9 chunks +10 lines, -44 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 10 chunks +46 lines, -42 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.h View 5 chunks +3 lines, -28 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 12 chunks +11 lines, -96 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 13 chunks +52 lines, -51 lines 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/core_audio_util_win.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M media/audio/win/core_audio_util_win_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M media/audio/win/device_enumeration_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Created Revert of Switch to STA mode for audio thread and WASAPI I/O streams.
5 years, 8 months ago (2015-04-27 20:20:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111503003/1
5 years, 8 months ago (2015-04-27 20:21:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 20:23:09 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 20:23:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b70e5168cb06cefc077b0cfced369409941c52e4
Cr-Commit-Position: refs/heads/master@{#327115}

Powered by Google App Engine
This is Rietveld 408576698