Better handling of permission errors during install.

Better handling of permission errors during install.

Error messages are now more accurate and descriptive.

BUG=155411, 151684
Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1448

[binji, 2012-10-12 18:43:02]

lgtm

http://codereview.chromium.org/11115018/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right):

http://codereview.chromium.org/11115018/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:261: "have them
locked.")
You probably still want to mention Visual studio and MSBuild, or this error
isn't particularly actionable (how do I find which programs are accessing those
files?)

[binji, 2012-10-12 18:43:37]

Also, we should really have tests for all of these cases.

[Sam Clegg, 2012-10-12 18:51:58]

http://codereview.chromium.org/11115018/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right):

http://codereview.chromium.org/11115018/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:261: "have them
locked.")
On 2012/10/12 18:43:02, binji wrote:
> You probably still want to mention Visual studio and MSBuild, or this error
> isn't particularly actionable (how do I find which programs are accessing
those
> files?)

We already check for them explicitly/separately above and
warn the user about those instances.

[Sam Clegg, 2012-10-12 18:53:44]

On 2012/10/12 18:43:37, binji wrote:
> Also, we should really have tests for all of these cases.

Hm.. interesting.  Let me think about how best to do that.
Are you thinking unittests of these python functions or
end to end tests that run the install.bat and see what it
produces?

[binji, 2012-10-12 18:55:14]

On 2012/10/12 18:53:44, Sam Clegg wrote:
> On 2012/10/12 18:43:37, binji wrote:
> > Also, we should really have tests for all of these cases.
> 
> Hm.. interesting.  Let me think about how best to do that.
> Are you thinking unittests of these python functions or
> end to end tests that run the install.bat and see what it
> produces?

End to end tests, probably. It would be good to verify that we can reproduce
errors that users may see.