Better handling of permission errors during install.

visual_studio/NativeClientVSAddIn/InstallerResources/install.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Copies necessary add-in files into place to install the add-in.
 
 This script will copy the necessary files for the Visual Studio add-in
 to where Visual Studio can find them. It assumes the current directory
 contains the necessary files to copy.
@@ skipping 27 matching lines @@
 
 
 def UninstallDirectory(directory):
   if os.path.exists(directory):
     shutil.rmtree(directory)
     print 'Removed: %s' % (directory)
 
 
 def UninstallFile(file_path):
   if os.path.exists(file_path):
+    if not os.access(file_path, os.W_OK):
+      raise InstallError("File is marked as read-only: %s.\n"
+                         "Please correct and try again." % file_path)
     os.remove(file_path)
     print 'Removed: %s' % (file_path)
 
 
 def Uninstall(platform_dirs, addin_directory):
   for dirname in platform_dirs:
     UninstallDirectory(dirname)
   for file_name in ADDIN_FILES:
     UninstallFile(os.path.join(addin_directory, file_name))
 
@@ skipping 184 matching lines @@
   try:
     rtn = main()
   except InstallError as e:
     print
     print e
   except shutil.Error as e:
     print "Error while copying file. Please ensure file is not in use."
     print e
   except WindowsError as e:
     if e.winerror == 5:
-      print "Access denied error.  Please ensure Visual Studio and MSBuild"
-      print "processes are closed."
+      print e
+      print("The install script failed to write to the files mentioned above")
+      if ctypes.windll.shell32.IsUserAnAdmin() != 1:
+        print("Please try running as administrator.")
+      else:
+        print("Please check for any running programs that might "
+              "have them locked.")

[binji, 2012/10/12 18:43:02]

You probably still want to mention Visual studio and MSBuild, or this error
isn't particularly actionable (how do I find which programs are accessing those
files?)

[Sam Clegg, 2012/10/12 18:51:58]

We already check for them explicitly/separately above and
warn the user about those instances.

     else:
       raise
   sys.exit(rtn)