Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 11112004: Bug fix: in process router should not expect msg->is_sync (Closed)

Created:
8 years, 2 months ago by victorhsieh
Modified:
8 years, 2 months ago
Reviewers:
brettw, raymes
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Peng
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Bug fix: in process router should not expect a sync message from host to plugin. Replies to sync messages are not sync message. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/pepper/pepper_in_process_router.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
victorhsieh
Hey Raymes, this is what we discussed yesterday. Thanks for finding this with me.
8 years, 2 months ago (2012-10-11 23:06:39 UTC) #1
raymes
lgtm
8 years, 2 months ago (2012-10-12 18:41:45 UTC) #2
raymes
On 2012/10/12 18:41:45, raymes wrote: > lgtm Please update the description. The reason this is ...
8 years, 2 months ago (2012-10-12 18:45:51 UTC) #3
victorhsieh
On 2012/10/12 18:45:51, raymes wrote: > On 2012/10/12 18:41:45, raymes wrote: > > lgtm > ...
8 years, 2 months ago (2012-10-13 00:22:13 UTC) #4
raymes
+brettw for OWNERS
8 years, 2 months ago (2012-10-15 23:02:50 UTC) #5
brettw
lgtm
8 years, 2 months ago (2012-10-16 17:37:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/11112004/1
8 years, 2 months ago (2012-10-16 17:45:49 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 20:23:51 UTC) #8
Change committed as 162229

Powered by Google App Engine
This is Rietveld 408576698