webkit/plugins/webview_plugin.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/webview_plugin.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/plugins/webview_plugin.cc

diff --git a/webkit/plugins/webview_plugin.cc b/webkit/plugins/webview_plugin.cc

index 7d3dc7ed0281bc7f6afd452a74b8568e0ed185f7..9888b737ebf8a4962171a81027a44f196b6b395d 100644

--- a/webkit/plugins/webview_plugin.cc

+++ b/webkit/plugins/webview_plugin.cc

@@ -120,7 +120,8 @@ bool WebViewPlugin::getFormValue(WebString& value) {

}

void WebViewPlugin::paint(WebCanvas* canvas, const WebRect& rect) {

- gfx::Rect paintRect(rect_.Intersect(rect));

+ gfx::Rect paintRect = rect_;

+ paintRect.Intersect(rect);

if (paintRect.IsEmpty())

return;

« no previous file with comments | « webkit/plugins/ppapi/ppb_scrollbar_impl.cc ('k') | webkit/tools/test_shell/webwidget_host_gtk.cc » ('j') | no next file with comments »