webkit/plugins/ppapi/ppb_scrollbar_impl.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_scrollbar_impl.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/plugins/ppapi/ppb_scrollbar_impl.cc

diff --git a/webkit/plugins/ppapi/ppb_scrollbar_impl.cc b/webkit/plugins/ppapi/ppb_scrollbar_impl.cc

index 1a190bb0c8ce29ab4572eba2c624d9f327494636..7242de62b160b1f6bd06fe6c167d46802d9160c5 100644

--- a/webkit/plugins/ppapi/ppb_scrollbar_impl.cc

+++ b/webkit/plugins/ppapi/ppb_scrollbar_impl.cc

@@ -211,7 +211,7 @@ void PPB_Scrollbar_Impl::invalidateScrollbarRect(

rect.y,

rect.width,

rect.height);

- dirty_ = dirty_.Union(gfx_rect);

+ dirty_.Union(gfx_rect);

// Can't call into the client to tell them about the invalidate right away,

// since the PPB_Scrollbar_Impl code is still in the middle of updating its

// internal state.

« no previous file with comments | « webkit/plugins/ppapi/ppb_graphics_2d_impl.cc ('k') | webkit/plugins/webview_plugin.cc » ('j') | no next file with comments »