chrome/browser/ui/views/extensions/extension_dialog.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc ('k') | chrome/browser/ui/views/notifications/balloon_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_dialog.cc

diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc

index c290fc14a3b0d74ca608784dcb6c6d7aaedb2c51..095760cbf82e8e84e068da46da0cd64fb3aa71c8 100644

--- a/chrome/browser/ui/views/extensions/extension_dialog.cc

+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc

@@ -167,7 +167,7 @@ void ExtensionDialog::InitWindow(BaseWindow* base_window,

gfx::Rect screen_rect = gfx::Screen::GetScreenFor(parent)->

GetDisplayNearestPoint(center).bounds();

gfx::Rect bounds_rect = gfx::Rect(x, y, width, height);

- bounds_rect = bounds_rect.AdjustToFit(screen_rect);

+ bounds_rect.AdjustToFit(screen_rect);

window_->SetBounds(bounds_rect);

window_->Show();