chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

index 3ac069e6c9387f03f04ecde49346c97abc490650..5ba5bd1840f3f2c4937145d57b3488e169e3634f 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

@@ -1497,7 +1497,8 @@ class BookmarkBarViewTest17 : public BookmarkBarViewEventTestBase {

// sure the click is always on the child menu.

gfx::Rect context_rect = context_menu->GetSubmenu()->GetBoundsInScreen();

gfx::Rect child_menu_rect = child_menu->GetBoundsInScreen();

- gfx::Rect clickable_rect = child_menu_rect.Subtract(context_rect);

+ gfx::Rect clickable_rect = child_menu_rect;

+ clickable_rect.Subtract(context_rect);

ASSERT_FALSE(clickable_rect.IsEmpty());

observer_.set_task(CreateEventTask(this, &BookmarkBarViewTest17::Step4));

MoveMouseAndPress(clickable_rect.CenterPoint(), ui_controls::RIGHT,

« no previous file with comments | « chrome/browser/ui/tabs/dock_info.cc ('k') | chrome/browser/ui/views/extensions/extension_dialog.cc » ('j') | no next file with comments »