cc/delegated_renderer_layer_impl.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/delegated_renderer_layer_impl.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/delegated_renderer_layer_impl.cc

diff --git a/cc/delegated_renderer_layer_impl.cc b/cc/delegated_renderer_layer_impl.cc

index 3f77a55dc9bc2d6ede70009de2a594e50da5389a..4101ab727f1515cb29cc0c298d4e2230e61589ed 100644

--- a/cc/delegated_renderer_layer_impl.cc

+++ b/cc/delegated_renderer_layer_impl.cc

@@ -58,7 +58,8 @@ void DelegatedRendererLayerImpl::setRenderPasses(ScopedPtrVector<RenderPass>& re

if (!m_renderPassesInDrawOrder.isEmpty()) {

gfx::RectF newRootDamage = m_renderPassesInDrawOrder.last()->damageRect();

- m_renderPassesInDrawOrder.last()->setDamageRect(oldRootDamage.Union(newRootDamage));

+ newRootDamage.Union(oldRootDamage);

+ m_renderPassesInDrawOrder.last()->setDamageRect(newRootDamage);

}

« no previous file with comments | « ash/wm/workspace/workspace_window_resizer.cc ('k') | cc/direct_renderer.cc » ('j') | no next file with comments »