ash/wm/workspace/workspace_window_resizer.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_window_resizer.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/workspace/workspace_window_resizer.cc

diff --git a/ash/wm/workspace/workspace_window_resizer.cc b/ash/wm/workspace/workspace_window_resizer.cc

index 26309d1e1e30ea517ed8eaf01616a051ce9aee2d..5ede0c24443370736fc091f3854253f9881ea6b6 100644

--- a/ash/wm/workspace/workspace_window_resizer.cc

+++ b/ash/wm/workspace/workspace_window_resizer.cc

@@ -671,8 +671,8 @@ void WorkspaceWindowResizer::UpdateDragPhantomWindow(const gfx::Rect& bounds,

const gfx::Rect root_bounds_in_screen(another_root->GetBoundsInScreen());

const gfx::Rect bounds_in_screen =

ScreenAsh::ConvertRectToScreen(window()->parent(), bounds);

- const gfx::Rect bounds_in_another_root =

- root_bounds_in_screen.Intersect(bounds_in_screen);

+ gfx::Rect bounds_in_another_root = root_bounds_in_screen;

+ bounds_in_another_root.Intersect(bounds_in_screen);

const float fraction_in_another_window =

(bounds_in_another_root.width() * bounds_in_another_root.height()) /

« no previous file with comments | « ash/wm/workspace/workspace_layout_manager2.cc ('k') | cc/delegated_renderer_layer_impl.cc » ('j') | no next file with comments »