ash/tooltips/tooltip_controller_unittest.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/tooltips/tooltip_controller_unittest.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/tooltips/tooltip_controller_unittest.cc

diff --git a/ash/tooltips/tooltip_controller_unittest.cc b/ash/tooltips/tooltip_controller_unittest.cc

index d48db06881b98c2135ebfefd1a7bfd31ac63f214..9efbd753c3998986dd3233ca9738cdeea9c4fb66 100644

--- a/ash/tooltips/tooltip_controller_unittest.cc

+++ b/ash/tooltips/tooltip_controller_unittest.cc

@@ -72,7 +72,7 @@ void AddViewToWidgetAndResize(views::Widget* widget, views::View* view) {

contents_view->AddChildView(view);

view->SetBounds(contents_view->width(), 0, 100, 100);

gfx::Rect contents_view_bounds = contents_view->bounds();

- contents_view_bounds = contents_view_bounds.Union(view->bounds());

+ contents_view_bounds.Union(view->bounds());

contents_view->SetBoundsRect(contents_view_bounds);

widget->SetBounds(gfx::Rect(widget->GetWindowBoundsInScreen().origin(),

contents_view_bounds.size()));

« no previous file with comments | « ash/tooltips/tooltip_controller.cc ('k') | ash/wm/base_layout_manager.cc » ('j') | no next file with comments »