ash/tooltips/tooltip_controller.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/tooltips/tooltip_controller.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/tooltips/tooltip_controller.cc

diff --git a/ash/tooltips/tooltip_controller.cc b/ash/tooltips/tooltip_controller.cc

index 3bb99bc7033d121fcae5f3d586628a43a9a83d6b..45c4785c081f034c93ce8c86c013bb5c6f1490fa 100644

--- a/ash/tooltips/tooltip_controller.cc

+++ b/ash/tooltips/tooltip_controller.cc

@@ -179,7 +179,8 @@ class TooltipController::Tooltip : public views::WidgetObserver {

if (tooltip_rect.bottom() > display_bounds.bottom())

tooltip_rect.set_y(mouse_pos.y() - tooltip_height);

- GetWidget()->SetBounds(tooltip_rect.AdjustToFit(display_bounds));

+ tooltip_rect.AdjustToFit(display_bounds);

+ GetWidget()->SetBounds(tooltip_rect);

}

views::Widget* GetWidget() {

« no previous file with comments | « ash/system/user/tray_user.cc ('k') | ash/tooltips/tooltip_controller_unittest.cc » ('j') | no next file with comments »