Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Issue 1110943003: Revert of Classify navigations without page id in parallel to the existing classifier. (Closed)

Created:
5 years, 7 months ago by vkuzkokov
Modified:
5 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Classify navigations without page id in parallel to the existing classifier. (patchset #35 id:680001 of https://codereview.chromium.org/1002803002/) Reason for revert: Very flaky on ChromeOS debug bots. See crbug.com/481910 Original issue's description: > Classify navigations without page id in parallel to the existing classifier. > > For now, this only happens in debug builds. > > BUG=369661 > TEST=NavigationControllerBrowserTest.NavigationTypeClassification_* > TEST=Every other test on the planet. > > Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff > Cr-Commit-Position: refs/heads/master@{#327122} > > Reverted: https://crrev.com/5348e920f4119aff9a4eb76c0965725dc85a66cc > Cr-Revert-Position: refs/heads/master@{#327152} > > Committed: https://crrev.com/5671403d44971669e4d81aecf3f002188ce0e95f > Cr-Commit-Position: refs/heads/master@{#327214} TBR=phajdan.jr@chromium.org,clamy@chromium.org,creis@chromium.org,hajimehoshi@chromium.org,isherman@chromium.org,jeremyim@chromium.org,mattm@chromium.org,mnaganov@chromium.org,mvanouwerkerk@chromium.org,nasko@chromium.org,stevenjb@chromium.org,bengr@chromium.org,cpu@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/49180eb13549e440bbd4f66390e32e84699dcdfd Cr-Commit-Position: refs/heads/master@{#327269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -1331 lines) Patch
M chrome/browser/chromeos/login/signin/merge_session_load_page_unittest.cc View 6 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page_unittest.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 19 chunks +41 lines, -61 lines 0 comments Download
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page_unittest.cc View 11 chunks +32 lines, -63 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 3 chunks +0 lines, -131 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 133 chunks +187 lines, -338 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 27 chunks +30 lines, -37 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 20 chunks +16 lines, -38 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 112 chunks +136 lines, -247 lines 0 comments Download
M content/common/frame_messages.h View 3 chunks +0 lines, -12 lines 0 comments Download
M content/common/navigation_params.h View 2 chunks +0 lines, -14 lines 0 comments Download
M content/common/navigation_params.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M content/public/common/frame_navigate_params.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/frame_navigate_params.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_renderer_host.h View 1 chunk +10 lines, -20 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M content/public/test/web_contents_tester.h View 1 chunk +7 lines, -18 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +16 lines, -13 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 7 chunks +4 lines, -16 lines 0 comments Download
M content/test/test_render_frame_host.h View 2 chunks +19 lines, -36 lines 0 comments Download
M content/test/test_render_frame_host.cc View 8 chunks +25 lines, -54 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/test/test_render_view_host.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/test/test_web_contents.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_web_contents.cc View 4 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vkuzkokov
Created Revert of Classify navigations without page id in parallel to the existing classifier.
5 years, 7 months ago (2015-04-28 12:06:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110943003/1
5 years, 7 months ago (2015-04-28 12:06:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 12:07:17 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 12:08:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49180eb13549e440bbd4f66390e32e84699dcdfd
Cr-Commit-Position: refs/heads/master@{#327269}

Powered by Google App Engine
This is Rietveld 408576698