Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1110943003: Revert of Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_render_frame_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 13d09524911be29b1e190bccc2b86e2f32f22e39..38e8ca7c3e2eb565e250cbeae92d020f0f4ea9e0 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -716,7 +716,6 @@
request_params_A.current_history_list_offset = 1;
request_params_A.pending_history_list_offset = 0;
request_params_A.page_id = 1;
- request_params_A.nav_entry_id = 1;
request_params_A.page_state = state_A;
NavigateMainFrame(common_params_A, StartNavigationParams(), request_params_A);
EXPECT_EQ(1, view()->historyBackListCount());
@@ -746,7 +745,6 @@
request_params.current_history_list_offset = 0;
request_params.pending_history_list_offset = 0;
request_params.page_id = 1;
- request_params.nav_entry_id = 1;
request_params.page_state = state_A;
NavigateMainFrame(common_params, StartNavigationParams(), request_params);
ProcessPendingMessages();
@@ -917,12 +915,12 @@
// ignored. See http://crbug.com/86758.
TEST_F(RenderViewImplTest, StaleNavigationsIgnored) {
// Load page A.
- LoadHTML("<div id=pagename>Page A</div>");
+ LoadHTML("<div>Page A</div>");
EXPECT_EQ(1, view()->history_list_length_);
EXPECT_EQ(0, view()->history_list_offset_);
// Load page B, which will trigger an UpdateState message for page A.
- LoadHTML("<div id=pagename>Page B</div>");
+ LoadHTML("<div>Page B</div>");
EXPECT_EQ(2, view()->history_list_length_);
EXPECT_EQ(1, view()->history_list_offset_);
@@ -938,7 +936,7 @@
EXPECT_EQ(1, page_id_A);
render_thread_->sink().ClearMessages();
- // Back to page A (nav_entry_id 1) and commit.
+ // Back to page A (page_id 1) and commit.
CommonNavigationParams common_params_A;
RequestNavigationParams request_params_A;
common_params_A.navigation_type = FrameMsg_Navigate_Type::NORMAL;
@@ -947,21 +945,15 @@
request_params_A.current_history_list_offset = 1;
request_params_A.pending_history_list_offset = 0;
request_params_A.page_id = 1;
- request_params_A.nav_entry_id = 1;
request_params_A.page_state = state_A;
NavigateMainFrame(common_params_A, StartNavigationParams(), request_params_A);
ProcessPendingMessages();
// A new navigation commits, clearing the forward history.
- LoadHTML("<div id=pagename>Page C</div>");
+ LoadHTML("<div>Page C</div>");
EXPECT_EQ(2, view()->history_list_length_);
EXPECT_EQ(1, view()->history_list_offset_);
EXPECT_EQ(3, view()->page_id_); // page C is now page id 3
- int was_page_c = -1;
- base::string16 check_page_c = base::ASCIIToUTF16(
- "Number(document.getElementById('pagename').innerHTML == 'Page C')");
- EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c));
- EXPECT_EQ(1, was_page_c);
// The browser then sends a stale navigation to B, which should be ignored.
CommonNavigationParams common_params_B;
@@ -972,7 +964,6 @@
request_params_B.current_history_list_offset = 0;
request_params_B.pending_history_list_offset = 1;
request_params_B.page_id = 2;
- request_params_B.nav_entry_id = 2;
request_params_B.page_state =
state_A; // Doesn't matter, just has to be present.
NavigateMainFrame(common_params_B, StartNavigationParams(), request_params_B);
@@ -981,9 +972,6 @@
EXPECT_EQ(2, view()->history_list_length_);
EXPECT_EQ(1, view()->history_list_offset_);
EXPECT_EQ(3, view()->page_id_); // page C, not page B
- was_page_c = -1;
- EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c));
- EXPECT_EQ(1, was_page_c);
// Check for a valid DidDropNavigation message.
ProcessPendingMessages();
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_render_frame_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698