Issue 11108011: Ensure that we do not accidentally emit debug code.

Issue 11108011: Ensure that we do not accidentally emit debug code. (Closed)

Created:
8 years, 2 months ago by Sven Panne

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure that we do not accidentally emit debug code. The call sites are more concise, the naming is better and at least one case of superfluous code in release mode was removed. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12712

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed indentation #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+269 lines, -286 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		6 chunks	+16 lines, -25 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View		1 chunk	+12 lines, -11 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+30 lines, -22 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		4 chunks	+4 lines, -8 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		3 chunks	+31 lines, -27 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View		6 chunks	+16 lines, -25 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View		1 chunk	+12 lines, -11 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View		1 chunk	+34 lines, -26 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	3 chunks	+5 lines, -11 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	6 chunks	+8 lines, -14 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		1 chunk	+16 lines, -15 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		4 chunks	+60 lines, -58 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a few nits). https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.cc#newcode4277 src/arm/lithium-codegen-arm.cc:4277: __ AssertSmi(r0); Indentation is ...

8 years, 2 months ago (2012-10-12 11:00:22 UTC) #1

Sven Panne

8 years, 2 months ago (2012-10-12 11:05:36 UTC) #2

Fixed nits, landing...

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.c...
src/arm/lithium-codegen-arm.cc:4277: __ AssertSmi(r0);
On 2012/10/12 11:00:22, Michael Starzinger wrote:
> Indentation is off.

Done.

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x64.cc#new...
src/x64/code-stubs-x64.cc:1300: __ AssertRootValue(heap_number_map,
On 2012/10/12 11:00:22, Michael Starzinger wrote:
> Indentation is off.

Done.

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codegen-x64.c...
src/x64/lithium-codegen-x64.cc:4207: __ AssertSmi(input);
On 2012/10/12 11:00:22, Michael Starzinger wrote:
> Indentation is off.

Done.

Expand Messages | Collapse Messages