chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h - Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('K') | « chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('k') | chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h

diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h b/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h

index 89c5395101322ce8a0404f85f2898166b638471c..5c3c78eb913d76939f2beaf1e07379b1f93c6a39 100644

--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h

+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h

@@ -21,10 +21,9 @@ class URLRequest;

// Factory for creating a SafeBrowsingResourceThrottle. If a factory is

// registered, the factory's CreateResourceThrottle() is called. Otherwise,

-// when SAFE_BROWSING_DB_LOCAL is enabled, a new

+// if SAFE_BROWSING_DB_LOCAL || SAFE_BROWSING_DB_REMOTE is enabled, a new

// SafeBrowsingResourceThrottle is returned, or NULL if only

// SAFE_BROWSING_SERVICE is enabled.

-// TODO(nparker): Add support SAFE_BROWSING_DB_REMOTE

class SafeBrowsingResourceThrottleFactory {

public:

// Registers a factory. Does not take the ownership of the factory. The