chrome/browser/renderer_host/safe_browsing_resource_throttle.cc - Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_impl.cc ('K') | « chrome/browser/profiles/profile_impl.cc ('k') | chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

index 5eb2f6a577a23d59706cf1e7d63c9266fb739c83..ae055d5a23400894a081441068fa60abbc489636 100644

--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

@@ -91,12 +91,6 @@ void SafeBrowsingResourceThrottle::OnCheckBrowseUrlResult(

CHECK(url == url_being_checked_) << "Was expecting: " << url_being_checked_

<< " but got: " << url;

-#if defined(OS_ANDROID)

- // Temporarily disable SB interstitial during Finch experiment.

- // The database check is still exercised, but the interstitial never shown.

- threat_type = SB_THREAT_TYPE_SAFE;

-#endif

Nico 2015/05/13 00:07:23 Same question

Nathan Parker 2015/05/13 00:11:23 Acknowledged.

timer_.Stop(); // Cancel the timeout timer.

threat_type_ = threat_type;

state_ = STATE_NONE;