Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: chrome/browser/extensions/fake_safe_browsing_database_manager.cc

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h" 5 #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/bind_helpers.h" 11 #include "base/bind_helpers.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/run_loop.h" 13 #include "base/run_loop.h"
14 #include "base/thread_task_runner_handle.h" 14 #include "base/thread_task_runner_handle.h"
15 #include "chrome/browser/safe_browsing/safe_browsing_service.h" 15 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
16 #include "chrome/browser/safe_browsing/safe_browsing_util.h" 16 #include "chrome/browser/safe_browsing/safe_browsing_util.h"
17 17
18 namespace extensions { 18 namespace extensions {
19 19
20 FakeSafeBrowsingDatabaseManager::FakeSafeBrowsingDatabaseManager(bool enabled) 20 FakeSafeBrowsingDatabaseManager::FakeSafeBrowsingDatabaseManager(bool enabled)
21 : SafeBrowsingDatabaseManager( 21 : LocalSafeBrowsingDatabaseManager(
22 make_scoped_refptr(SafeBrowsingService::CreateSafeBrowsingService())), 22 make_scoped_refptr(SafeBrowsingService::CreateSafeBrowsingService())),
23 enabled_(enabled) { 23 enabled_(enabled) {
24 } 24 }
25 25
26 FakeSafeBrowsingDatabaseManager::~FakeSafeBrowsingDatabaseManager() { 26 FakeSafeBrowsingDatabaseManager::~FakeSafeBrowsingDatabaseManager() {
27 } 27 }
28 28
29 FakeSafeBrowsingDatabaseManager& FakeSafeBrowsingDatabaseManager::Enable() { 29 FakeSafeBrowsingDatabaseManager& FakeSafeBrowsingDatabaseManager::Enable() {
30 enabled_ = true; 30 enabled_ = true;
31 return *this; 31 return *this;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 return *this; 77 return *this;
78 } 78 }
79 79
80 FakeSafeBrowsingDatabaseManager& FakeSafeBrowsingDatabaseManager::RemoveUnsafe( 80 FakeSafeBrowsingDatabaseManager& FakeSafeBrowsingDatabaseManager::RemoveUnsafe(
81 const std::string& a) { 81 const std::string& a) {
82 unsafe_ids_.erase(a); 82 unsafe_ids_.erase(a);
83 return *this; 83 return *this;
84 } 84 }
85 85
86 void FakeSafeBrowsingDatabaseManager::NotifyUpdate() { 86 void FakeSafeBrowsingDatabaseManager::NotifyUpdate() {
87 SafeBrowsingDatabaseManager::NotifyDatabaseUpdateFinished(true); 87 LocalSafeBrowsingDatabaseManager::NotifyDatabaseUpdateFinished(true);
88 } 88 }
89 89
90 bool FakeSafeBrowsingDatabaseManager::CheckExtensionIDs( 90 bool FakeSafeBrowsingDatabaseManager::CheckExtensionIDs(
91 const std::set<std::string>& extension_ids, 91 const std::set<std::string>& extension_ids,
92 Client* client) { 92 Client* client) {
93 if (!enabled_) 93 if (!enabled_)
94 return true; 94 return true;
95 95
96 // Need to construct the full SafeBrowsingCheck rather than calling 96 // Need to construct the full SafeBrowsingCheck rather than calling
97 // OnCheckExtensionsResult directly because it's protected. Grr! 97 // OnCheckExtensionsResult directly because it's protected. Grr!
(...skipping 13 matching lines...) Expand all
111 std::vector<SBThreatType>(1, SB_THREAT_TYPE_EXTENSION))); 111 std::vector<SBThreatType>(1, SB_THREAT_TYPE_EXTENSION)));
112 112
113 for (size_t i = 0; i < extension_ids_vector.size(); ++i) { 113 for (size_t i = 0; i < extension_ids_vector.size(); ++i) {
114 const std::string& extension_id = extension_ids_vector[i]; 114 const std::string& extension_id = extension_ids_vector[i];
115 if (unsafe_ids_.count(extension_id)) 115 if (unsafe_ids_.count(extension_id))
116 safe_browsing_check->full_hash_results[i] = SB_THREAT_TYPE_EXTENSION; 116 safe_browsing_check->full_hash_results[i] = SB_THREAT_TYPE_EXTENSION;
117 } 117 }
118 118
119 base::ThreadTaskRunnerHandle::Get()->PostTask( 119 base::ThreadTaskRunnerHandle::Get()->PostTask(
120 FROM_HERE, 120 FROM_HERE,
121 base::Bind(&FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult, 121 base::Bind(&FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult, this,
122 this, 122 base::Passed(&safe_browsing_check)));
123 base::Passed(&safe_browsing_check),
124 client));
125 return false; 123 return false;
126 } 124 }
127 125
128 void FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult( 126 void FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult(
129 scoped_ptr<SafeBrowsingCheck> result, 127 scoped_ptr<SafeBrowsingCheck> result) {
130 Client* client) { 128 result->OnSafeBrowsingResult();
131 client->OnSafeBrowsingResult(*result);
132 } 129 }
133 130
134 } // namespace extensions 131 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698