Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 11106011: Test that built-in identifiers can be used as library prefixes. (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years ago
Reviewers:
bakster, gbracha, kasperl
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

Test that built-in identifiers can be used as library prefixes. Committed: https://code.google.com/p/dart/source/detail?r=15396

Patch Set 1 #

Patch Set 2 : Updated test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -0 lines) Patch
A dart/tests/language/built_in_identifier_prefix_library_abstract.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_as.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_dynamic.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_export.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_external.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_factory.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_get.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_implements.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_import.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_library.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_operator.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_part.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_set.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_static.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_library_typedef.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A dart/tests/language/built_in_identifier_prefix_test.dart View 1 chunk +215 lines, -0 lines 0 comments Download
M dart/tests/language/language.status View 1 3 chunks +3 lines, -0 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
FYI: Both dart2js and the VM fails this test.
8 years, 2 months ago (2012-10-12 09:33:36 UTC) #1
kasperl
LGTM.
8 years, 2 months ago (2012-10-12 09:34:16 UTC) #2
bakster
8 years, 2 months ago (2012-10-12 10:31:43 UTC) #3
Interesting set of tests. LGTM,
  Lars

Powered by Google App Engine
This is Rietveld 408576698