Issue 1110473002: [chrome/browser/renderer_context_menu] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110473002: [chrome/browser/renderer_context_menu] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/renderer_context_menu BUG=466848 Committed: https://crrev.com/df153bc9a03c549c3059264fdae03f600fa549b2 Cr-Commit-Position: refs/heads/master@{#327076}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_context_menu/spelling_menu_observer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110473002/1

5 years, 8 months ago (2015-04-27 17:33:36 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 18:26:46 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/df153bc9a03c549c3059264fdae03f600fa549b2
Cr-Commit-Position: refs/heads/master@{#327076}