chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc - Issue 1110473002: [chrome/browser/renderer_context_menu] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc

Issue 1110473002: [chrome/browser/renderer_context_menu] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc ('k') | chrome/browser/renderer_context_menu/spelling_menu_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc

diff --git a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc

index f8ac7ef29077e67bf8f583f96bb81c80e6c2fce4..a90bc44dbb2ef0cf34906213b6b3ad380373912f 100644

--- a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc

+++ b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc

@@ -44,7 +44,7 @@ SpellCheckerSubMenuObserver::~SpellCheckerSubMenuObserver() {

void SpellCheckerSubMenuObserver::InitMenu(

const content::ContextMenuParams& params) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// Add an item that toggles the spelling panel.

submenu_model_.AddCheckItem(