Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1110393003: drop interalization of strings entering global constant slots (Closed)

Created:
5 years, 7 months ago by dcarney
Modified:
5 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

drop interalization of strings entering global constant slots BUG= Committed: https://crrev.com/a338f2738a81a32476261218f18a60db3706e7ec Cr-Commit-Position: refs/heads/master@{#28155}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.cc View 1 7 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
lgtm
5 years, 7 months ago (2015-04-30 10:20:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110393003/20001
5 years, 7 months ago (2015-04-30 10:49:26 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 10:50:52 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 10:51:06 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a338f2738a81a32476261218f18a60db3706e7ec
Cr-Commit-Position: refs/heads/master@{#28155}

Powered by Google App Engine
This is Rietveld 408576698