Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: src/accessors.cc

Issue 1110393003: drop interalization of strings entering global constant slots (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/contexts.h" 9 #include "src/contexts.h"
10 #include "src/deoptimizer.h" 10 #include "src/deoptimizer.h"
(...skipping 1010 matching lines...) Expand 10 before | Expand all | Expand 10 after
1021 } 1021 }
1022 1022
1023 1023
1024 MUST_USE_RESULT static MaybeHandle<Object> ReplaceAccessorWithDataProperty( 1024 MUST_USE_RESULT static MaybeHandle<Object> ReplaceAccessorWithDataProperty(
1025 Isolate* isolate, Handle<JSObject> object, Handle<Name> name, 1025 Isolate* isolate, Handle<JSObject> object, Handle<Name> name,
1026 Handle<Object> value, bool is_observed, Handle<Object> old_value) { 1026 Handle<Object> value, bool is_observed, Handle<Object> old_value) {
1027 LookupIterator it(object, name); 1027 LookupIterator it(object, name);
1028 CHECK_EQ(LookupIterator::ACCESSOR, it.state()); 1028 CHECK_EQ(LookupIterator::ACCESSOR, it.state());
1029 DCHECK(it.HolderIsReceiverOrHiddenPrototype()); 1029 DCHECK(it.HolderIsReceiverOrHiddenPrototype());
1030 it.ReconfigureDataProperty(value, it.property_details().attributes()); 1030 it.ReconfigureDataProperty(value, it.property_details().attributes());
1031 value = it.WriteDataValue(value); 1031 it.WriteDataValue(value);
1032 1032
1033 if (is_observed && !old_value->SameValue(*value)) { 1033 if (is_observed && !old_value->SameValue(*value)) {
1034 return JSObject::EnqueueChangeRecord(object, "update", name, old_value); 1034 return JSObject::EnqueueChangeRecord(object, "update", name, old_value);
1035 } 1035 }
1036 1036
1037 return value; 1037 return value;
1038 } 1038 }
1039 1039
1040 1040
1041 MUST_USE_RESULT static MaybeHandle<Object> SetFunctionLength( 1041 MUST_USE_RESULT static MaybeHandle<Object> SetFunctionLength(
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
1486 info->set_data(Smi::FromInt(index)); 1486 info->set_data(Smi::FromInt(index));
1487 Handle<Object> getter = v8::FromCData(isolate, &ModuleGetExport); 1487 Handle<Object> getter = v8::FromCData(isolate, &ModuleGetExport);
1488 Handle<Object> setter = v8::FromCData(isolate, &ModuleSetExport); 1488 Handle<Object> setter = v8::FromCData(isolate, &ModuleSetExport);
1489 info->set_getter(*getter); 1489 info->set_getter(*getter);
1490 if (!(attributes & ReadOnly)) info->set_setter(*setter); 1490 if (!(attributes & ReadOnly)) info->set_setter(*setter);
1491 return info; 1491 return info;
1492 } 1492 }
1493 1493
1494 1494
1495 } } // namespace v8::internal 1495 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698