Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1110203002: Revert of Add a slimming paint version of the r&r key silk case benchmark (Closed)

Created:
5 years, 7 months ago by pdr.
Modified:
5 years, 7 months ago
Reviewers:
sullivan, chrishtr
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a slimming paint version of the r&r key silk case benchmark (patchset #1 id:1 of https://codereview.chromium.org/1106823003/) Reason for revert: Turns out, we really only care about the smoothness version of this benchmark. I'm going to revert this change and put up a new patch to enable the key silk cases smoothness benchmark with slimming paint enabled. Original issue's description: > Add a slimming paint version of the r&r key silk case benchmark > > This patch adds a version of rasterize and record on key silk cases with > --enable-slimming-paint. > > BUG=464910 > > Committed: https://crrev.com/da8b63007bd79a03f9d5429d75511db8b723a2ea > Cr-Commit-Position: refs/heads/master@{#327162} TBR=chrishtr@chromium.org,sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464910 Committed: https://crrev.com/73d581341c40a225475a60f35a695f7b076c70d2 Cr-Commit-Position: refs/heads/master@{#327318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pdr.
Created Revert of Add a slimming paint version of the r&r key silk case benchmark
5 years, 7 months ago (2015-04-28 17:49:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110203002/1
5 years, 7 months ago (2015-04-28 17:50:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 17:52:23 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 17:53:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73d581341c40a225475a60f35a695f7b076c70d2
Cr-Commit-Position: refs/heads/master@{#327318}

Powered by Google App Engine
This is Rietveld 408576698