Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1106823003: Add a slimming paint version of the r&r key silk case benchmark (Closed)

Created:
5 years, 8 months ago by pdr.
Modified:
5 years, 8 months ago
Reviewers:
sullivan, chrishtr
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a slimming paint version of the r&r key silk case benchmark This patch adds a version of rasterize and record on key silk cases with --enable-slimming-paint. BUG=464910 Committed: https://crrev.com/da8b63007bd79a03f9d5429d75511db8b723a2ea Cr-Commit-Position: refs/heads/master@{#327162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pdr.
Test run: https://codereview.chromium.org/1109533004
5 years, 8 months ago (2015-04-24 22:56:42 UTC) #2
pdr.
On 2015/04/24 at 22:56:42, pdr wrote: > Test run: https://codereview.chromium.org/1109533004 My test run seems to ...
5 years, 8 months ago (2015-04-24 23:32:53 UTC) #4
sullivan
On 2015/04/24 23:32:53, pdr wrote: > On 2015/04/24 at 22:56:42, pdr wrote: > > Test ...
5 years, 8 months ago (2015-04-27 14:01:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106823003/1
5 years, 8 months ago (2015-04-27 20:32:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 22:48:35 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da8b63007bd79a03f9d5429d75511db8b723a2ea Cr-Commit-Position: refs/heads/master@{#327162}
5 years, 8 months ago (2015-04-27 22:49:33 UTC) #9
pdr.
5 years, 7 months ago (2015-04-28 17:49:44 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1110203002/ by pdr@chromium.org.

The reason for reverting is: Turns out, we really only care about the smoothness
version of this benchmark. I'm going to revert this change and put up a new
patch to enable the key silk cases smoothness benchmark with slimming paint
enabled..

Powered by Google App Engine
This is Rietveld 408576698