Issue 1110193002: Remove CTM-dependent paintBoxShadow() heuristic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110193002: Remove CTM-dependent paintBoxShadow() heuristic (Closed)

Created:
5 years, 7 months ago by f(malita)

Modified:
5 years, 7 months ago

Reviewers:
chrishtr, Stephen Chennney

CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, reed1, slimming-paint-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove CTM-dependent paintBoxShadow() heuristic When the background is opaque, we don't have to clip out box while drawing the shadow - we only do so as an overdraw optimization. That means we can always inset conservatively, without having to worry about the CTM. BUG=382491 R=chrishtr@chromium.org,schenney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194617

Patch Set 1 #

Patch Set 2 : expectations #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -17 lines)			Patch
	M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/core/paint/BoxPainter.cpp	View		2 chunks	+7 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

f(malita)

One test requires rebaselining due to a minor improvement: https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/61096/layout-test-results/fast/forms/submit/submit-appearance-basic-diffs.html

5 years, 7 months ago (2015-04-28 18:34:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110193002/20001

5 years, 7 months ago (2015-04-28 18:43:11 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-04-28 19:49:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194617

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages