Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1110173002: Do circular clipping in normalized space (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M gm/circularclips.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 1 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 7 months ago (2015-04-28 19:30:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110173002/10003
5 years, 7 months ago (2015-04-28 19:31:15 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-04-28 19:31:17 UTC) #5
jvanverth1
lgtm
5 years, 7 months ago (2015-04-28 19:33:19 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 19:43:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:10003) as
https://skia.googlesource.com/skia/+/fcabe429a4cd55d4b0b6c3e7b8b648fe8b35924d

Powered by Google App Engine
This is Rietveld 408576698