Issue 11099046: Fix output names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11099046: Fix output names (Closed)

Created:
8 years, 2 months ago by Sam Clegg

Modified:
8 years, 2 months ago

Reviewers:
noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Put output files in different folders as VS users would expect. Also, add more quotes to create_nmf args. BUG=155087 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1441

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -12 lines)			Patch
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Props/nacl_general.xml	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.default.props	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj	View	3 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

binji

8 years, 2 months ago (2012-10-10 22:23:22 UTC) #2

lgtm

http://codereview.chromium.org/11099046/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Props/nacl_general.xml
(right):

http://codereview.chromium.org/11099046/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Props/nacl_general.xml:80:
Category="General" Default="$(ProjectName)_$(TargetArchitecture)"
add comment about removing target architecture from targetname

Expand Messages | Collapse Messages